allow removing of code snippet #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbeatty
commented
Jul 10, 2017
| @@ -21,7 +21,7 @@ exports.testPage = Joi.object().keys({ | |||
| setup: mediumText, | |||
| teardown: mediumText, | |||
| test: Joi.array().required().min(2).items(Joi.object().required().keys({ | |||
| title: Joi.string().required().trim().allow('').empty('').max(255).when('code', { | |||
There was a problem hiding this comment.
required and allow('') apparently don't mix
mathiasbynens
approved these changes
Jul 10, 2017
|
LGTM with build failure addressed |
|
Turns out this was more complicated because of the circular dependencies in Joi (hapijs/joi#588 hapijs/joi#1236). Added more tests to verify behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #309
This is the easier approach to allowing a code snippet to be removed although it would be nice to have a button or something. All of the server logic is already in place to deal with a deletion this way.